Skip to content

chore: 🤖 Add initial page layout for code editor + sidebar#3180

Merged
lisbet-alvarez merged 3 commits intollb/grants-builderfrom
ICU-18460-initial-page-layout-skeleton-for-code-editor-sidebar
Mar 4, 2026
Merged

chore: 🤖 Add initial page layout for code editor + sidebar#3180
lisbet-alvarez merged 3 commits intollb/grants-builderfrom
ICU-18460-initial-page-layout-skeleton-for-code-editor-sidebar

Conversation

@lisbet-alvarez
Copy link
Collaborator

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-18460

Description

Add initial page layout for the "Edit Grants" page for the code editor + sidebar.

Screenshots (if appropriate)

Screen.Recording.2026-02-25.at.12.34.35.PM.mov

How to Test

  1. Go to existing role
  2. Click "Manage" dropdown
  3. Click "Edit Grants" button
  4. Validate page header and buttons are visible.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boundary-ui Ready Ready Preview, Comment Mar 3, 2026 10:57pm
boundary-ui-desktop Ready Ready Preview, Comment Mar 3, 2026 10:57pm

Request Review

@lisbet-alvarez lisbet-alvarez added the a11y-tests Runs our a11y tests when label added to PR label Feb 25, 2026
@lisbet-alvarez lisbet-alvarez marked this pull request as ready for review February 25, 2026 21:21
@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner February 25, 2026 21:21
ZedLi
ZedLi previously approved these changes Feb 26, 2026
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a heads up there could be some merge conflicts with #3115

DhariniJeeva
DhariniJeeva previously approved these changes Feb 26, 2026
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

DhariniJeeva
DhariniJeeva previously approved these changes Feb 27, 2026
priya-patel04
priya-patel04 previously approved these changes Mar 2, 2026
cameronperera
cameronperera previously approved these changes Mar 3, 2026
@lisbet-alvarez lisbet-alvarez merged commit 25935dc into llb/grants-builder Mar 4, 2026
13 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-18460-initial-page-layout-skeleton-for-code-editor-sidebar branch March 4, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y-tests Runs our a11y tests when label added to PR addons admin ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants